search

patrickfuller / imolecule

An embeddable webGL molecule viewer and file format converter.
http://patrickfuller.github.io/imolecule/
MIT License
86 stars 18 forks source link

Why is the package stored in `python` instead of `imolecule`? #13

Closed ctk3b closed 9 years ago

ctk3b commented 9 years ago

Hey Pat, I'm trying to use imolecule in another project and would need to make some small tweaks. I'll file a PR for them later but was curious about the choice to name the folder containing the package python instead of the more standard imolecule?

This prevents me from running python setup.py develop which is how I normally install packages I want to fiddle with. How do you do this locally?

For the record, just changing the name of the folder and adjusting the entry in setup.py fixes this issue for me but I may just not be using it the same way that you are.

This is the relatively obvious output in case you're curious:

$ python setup.py develop
Traceback (most recent call last):
  File "setup.py", line 2, in <module>
    from python import __version__
  File "/Users/ctk3b/imolecule/python/__init__.py", line 1, in <module>
    from imolecule.notebook import draw, generate, to_json
ImportError: No module named 'imolecule'
ctk3b commented 9 years ago

14 shows the difference in case you're curious.

patrickfuller commented 9 years ago

Hey Christoph,

That's great!

Regarding the weird naming scheme, it's mainly because imolecule started as a javascript project. The IPython functionality was an add-on, but I think it's gradually become the main use of the project.

I'm open to re-organizing the project structure, but I think it needs a couple more changes to make it PyPI + node compatible. I'll leave some comments on the pull request.

ctk3b commented 9 years ago

Resolved in #14