search

patrickfuller / imolecule

An embeddable webGL molecule viewer and file format converter.
http://patrickfuller.github.io/imolecule/
MIT License
86 stars 18 forks source link

Draw bonds between atoms with unknown element. #24

Closed ctk3b closed 8 years ago

ctk3b commented 8 years ago

Currently, when an unknown element is present in the file, bonds are not drawn to those atoms.

Also added a function which enables adding new "elements" with customized visuals, useful when, for example, trying to represent a coarse-grained system.

patrickfuller commented 8 years ago

Looks good to me. Thanks for the pull request.

ctk3b commented 8 years ago

Thanks! Could you also add an updated version of imolecule.min.js and/or contribute your build scripts for that? I can also add mine instead if your prefer.

patrickfuller commented 8 years ago

My 'build' is really lazy. In the imolecule/js folder, I run

uglifyjs jquery-ui.resizable.js three.min.js TrackballControls.js ShaderToon.js imolecule.js > build/imolecule.min.js

I'll do this in the next commit and increment the pypi version.

ctk3b commented 8 years ago

This could probably also be done on Travis with every commit.

patrickfuller commented 8 years ago

That's much smarter.