search

patrickhulce / fontmin-webpack

Minifies icon fonts to just the used glyphs.
MIT License
139 stars 19 forks source link

fix: support multiple assets (findRegularFontFiles) #13

Closed mochiya98 closed 5 years ago

mochiya98 commented 5 years ago

make it possible to find all assets.

patrickhulce commented 5 years ago

Would you mind explaining the use case and/or following up with a test so we capture this better and don't break in the future?

mochiya98 commented 5 years ago

Thanks @patrickhulce ok. I'll add tests later.

I would be happy if you could fix nukecss package. (for debugging)
I couldn't install on latest environment.

https://github.com/patrickhulce/nukecss/blob/master/package.json#L6

  "bin": {
-    "bin/nukecss.js": "nukecss"
+    "nukecss": "bin/nukecss.js"
  },

https://github.com/patrickhulce/nukecss-webpack/blob/master/package.json#L36 https://github.com/patrickhulce/fontmin-webpack/blob/master/package.json#L50

fontmin-webpack (devDependencies)
 -> nukecss-webpack
   -> nukecss
patrickhulce commented 5 years ago

Oh sure, yeah I never documented/officially supported a real CLI sorry about that!

mochiya98 commented 5 years ago

thank you for your help.
check out that :)