search

patrickkeenan / sketch-framer-states

Export artboards from Sketch as states for Framer
20 stars 0 forks source link

maskFrame x/y being improperly set #16

Closed cleercode closed 10 years ago

cleercode commented 10 years ago

metadata_for calculates x and y relative to parent. Masks are separate layers in Sketch, so their x/y gets calculated relative to the group they're masking, but framer.states.js uses this x/y directly.

Bigger question: any reason to not just export the mask metadata as frame instead of a separate property maskFrame?

patrickkeenan commented 10 years ago

Agreed, this is legacy code. I think we should also move to CSS for all shadows, and potentially for all boxes in general.

Also, I just quickly added in a mainframe to crop all layers. I think that will be a good way to put some chrome around it and have some presets for iPhone/nexus/etc. We can grab the dimensions of the artboard and assume those

On Friday, May 16, 2014 12:49:43 AM, Chris Lee notifications@github.com wrote:

metadata_for calculates x and y relative to parent. Masks are separate layers in Sketch, so their x/y gets calculated relative to the group they're masking, but framer.states.js uses this x/y directly.

Bigger question: any reason to not just export the mask metadata as frameinstead of a separate property maskFrame?

— Reply to this email directly or view it on GitHubhttps://github.com/patrickkeenan/sketch-framer-states/issues/16 .