search

patrickkeenan / sketch-framer-states

Export artboards from Sketch as states for Framer
20 stars 0 forks source link

Remove rectAccoutingForStyle #29

Open patrickkeenan opened 10 years ago

patrickkeenan commented 10 years ago

This constantly breaks my dimensions. Its necessary to do shadows and outer borders, but I think we should just not support shadows that are not on the base shape of a layer. Alternatively, people could make a transparent box for things. I don't know why this causes such an issue, but its always a problem for me.

cleercode commented 10 years ago

:/ I was actually aiming to make shadow support better, since I use it all the time and the dimensions never work as I want.

patrickkeenan commented 10 years ago

What are your thoughts on how to make it better? Would that be through CSS or through better sizing of the PNGs?

cleercode commented 10 years ago

Well, both, but more immediately, better sizing of PNGs. sketch-framer-3 seems to do a better job here, but I haven't looked into implementation.