Closed isadovskiy closed 9 years ago
Code is adjusted. Please check for the changes.
two tiny nits, then squash down to a single commit and git push --force
'er back up
Please check now
done
:hand:
cool, thanks!
Patrick, please review this commit as well: https://github.com/isadovskiy/grunt-compile-handlebars/commit/44e56f5a4fbb935f2eab5a9bd989d3735ce63afa
I updated README with inline JSON support for globals. Also fixed few formatting issues. And increased the version to 0.7.9 and updated the change log.
You can check how updated README looks here: https://github.com/isadovskiy/grunt-compile-handlebars/tree/globals-objects
Let me know if you are fine with these changes and I'll create another pull request for.
I am bumping the version to 1.0 in the next day or two, and will update the version and readme then. Thanks for the initiative, though!
BTW, did you think about moving configuration properties to grunt "options" section? This would allow to configure common settings on task level.
Right now to have 2 similar build configurations with small differences developer needs to duplicate a lot of configuration options.
PRs welcome! :)
On Mon, Dec 1, 2014, 4:38 AM isadovskiy notifications@github.com wrote:
BTW, did you think about moving configuration properties to grunt "options" section? This would allow to configure common settings on task level.
Right now to have 2 similar build configurations with small differences developer needs to duplicate a lot of configuration options.
— Reply to this email directly or view it on GitHub https://github.com/patrickkettner/grunt-compile-handlebars/pull/38#issuecomment-65039975 .
See more details in https://github.com/patrickkettner/grunt-compile-handlebars/pull/37