search

patrickkettner / grunt-compile-handlebars

grunt plugin to compile static html from a handlebars plugin
MIT License
115 stars 29 forks source link

adding support for partial,helpers; fixes for jslint #6

Closed RobinQu closed 11 years ago

RobinQu commented 11 years ago

combine all changes into a single commit

patrickkettner commented 11 years ago

Looks beautiful, could you update the tests and readme to to show an example of the new feature, and then we will get this puppy shipped.

RobinQu commented 11 years ago

BTW: At present, you have to assign a single extension type for a bunch of files. Have you ever considered to alter the strategy to detect file names? For example:index.html.hbs will translate to index.html. And you only have to give a path of output folder.

patrickkettner commented 11 years ago

Hey @RobinQu - did you see your tests are failing?

I'm more than open to that idea, pull requests are welcome :]

RobinQu commented 11 years ago

Sorry, I missed the test files in last commit.

And if the naming strategy is to be implemented, it will be necessary for the plugin users to rewrite their grunt config or this plugin will fail. What's your opinion?

patrickkettner commented 11 years ago

Its hard for me to see without the code, but why wouldn't both styles be available.

If it truly is better, though, thats what semvar is for. So that would be ok.

patrickkettner commented 11 years ago

@RobinQu please feel free to open up another request with that feature.

Thanks again for this!

RobinQu commented 11 years ago

Handlebars and grunt are important in our front-end stack. Will hand out new commits ASAP.

在 2013年10月22日，下午2:47，patrick kettner notifications@github.com 写道：

@RobinQu please feel free to open up another request with that feature.

Thanks again for this!

— Reply to this email directly or view it on GitHub.

patrickkettner commented 11 years ago

released in 0.6.1