patricklaf / SNMP

Simple Network Management Protocol library for Arduino
MIT License
10 stars 1 forks source link

Use IPAddress object instead of null pointer in IPAddressBER #10

Closed cydanil closed 3 weeks ago

cydanil commented 3 weeks ago

This MR aims to solve #9 , wherein it's described that the way IPAddressBER is initialized with a null pointer and is not compatible with the constructors provided by the arduino-esp32 library.

Here, we create an empty IPAddress object instead.

This was tested using the Agent.ino example on the ESP32-WROVER-E to validate the changes, and an STM32F103 (bluepill + w5500 module) to check that it's not breaking compatibility.

Thanks, Cyril

patricklaf commented 3 weeks ago

Nice, thanks.