search

patricklindsay / wice_grid

A Rails grid plugin to create grids with sorting, pagination, and (automatically generated) filters
http://wicegrid.herokuapp.com/
MIT License
33 stars 29 forks source link

Fix Rails 5.0 check for tag_options #1

Closed JasonBarnabe closed 6 years ago

JasonBarnabe commented 6 years ago

tag_options is private in Rails 5.0 and so is not found by respond_to? unless you tell it to include all methods.

patricklindsay commented 6 years ago

Thanks for the contribution.

What is this fixing exactly? I'm runnning on rails 5.1.5 and don't have any problems. If I'm going to start merging things into this fork I need to be confident that what I'm merging isn't going to break anything.

Ideally everything that is merged in should have release notes & test coverage.

JasonBarnabe commented 6 years ago

https://github.com/patricklindsay/wice_grid/commit/b6a2fefd4d10d2765bd313f6f6ecca7066020408 fixed Rails 5.1.x but broke Rails 5.0.x. This fixes Rails 5.0.x.

I can add this to the changelog.

Do the tests run on 5.0.x or just 5.1.x?

patricklindsay commented 6 years ago

No idea but I've created tasks to setup a CI build. I'd like this setup before adding anything else.

Checkout Setup CI Build project for more information.

patricklindsay commented 6 years ago

Ok I've tested this on Rails 5.0.7 & 5.1.7 so happy to merge. Thanks @JasonBarnabe !