search

patricklindsay / wice_grid

A Rails grid plugin to create grids with sorting, pagination, and (automatically generated) filters
http://wicegrid.herokuapp.com/
MIT License
33 stars 29 forks source link

Use Capybara negation matchers #14

Closed JasonBarnabe closed 6 years ago

JasonBarnabe commented 6 years ago

page.should_not have_content -> page.should have_no_content

This way, Capybara will wait a bit for the condition to become true, which will handle asynchronous JavaScript. This fixes a couple tests.

patricklindsay commented 6 years ago

Thanks.

Instead of using the old should syntax instead can we go with the new(ish) expect syntax?

JasonBarnabe commented 6 years ago

Yes, but that's a separate change. It can all be done at once with transpec.