search

patricklindsay / wice_grid

A Rails grid plugin to create grids with sorting, pagination, and (automatically generated) filters
http://wicegrid.herokuapp.com/
MIT License
33 stars 29 forks source link

Fixes #68 Problems with csv export #69

Closed dima4p closed 4 months ago

dima4p commented 5 years ago

There are 2 problems with the latest tests:

  1. phantomjs (not gem) is not installed on the testing machine.
  2. Two failing specs 
    rspec ./spec/features/auto_reloads3_request_spec.rb:74 # auto reloads 3 WiceGrid should filter by Due Date independantly
rspec ./spec/features/csv_export_request_spec.rb:9 # CSV export WiceGrid should export csv

    fail on master too.

kreintjes commented 4 years ago

@dima4p thanks! Will you have a look at the failing spec(s) as well?

rspec ./spec/features/auto_reloads3_request_spec.rb:74 # auto reloads 3 WiceGrid should filter by Due Date independantly
rspec ./spec/features/csv_export_request_spec.rb:9 # CSV export WiceGrid should export csv

(these do not fail on master on my machine locally)

dima4p commented 4 years ago

@dima4p thanks! Will you have a look at the failing spec(s) as well?

rspec ./spec/features/auto_reloads3_request_spec.rb:74 # auto reloads 3 WiceGrid should filter by Due Date independantly
rspec ./spec/features/csv_export_request_spec.rb:9 # CSV export WiceGrid should export csv

(these do not fail on master on my machine locally)

They do fail on my machine locally on upstream/master. Sorry.

dima4p commented 4 years ago

ruby 2.6.3

kreintjes commented 4 years ago

Hi Dima, I just tested your branch again, but 1 spec keeps failing while it does not on master (locally on my machine):

Failures:

  1) CSV export WiceGrid should export csv
     Failure/Error: expect(page).to have_content('ID;Title;Priority;Status;Project Name;')
       expected #has_content?("ID;Title;Priority;Status;Project Name;") to return true, got false
     # ./spec/features/csv_export_request_spec.rb:11:in `block (2 levels) in <top (required)>'

Finished in 1 minute 52.23 seconds (files took 5.64 seconds to load)
224 examples, 1 failure

Failed examples:

rspec ./spec/features/csv_export_request_spec.rb:9 # CSV export WiceGrid should export csv

This seems related to the CSV export, so I do think it is broken because of your changes. Could you please have a look at it again? I'm using ruby 2.6.5p114.

dima4p commented 4 years ago

Hi Dima, I just tested your branch again, but 1 spec keeps failing while it does not on master (locally on my machine):

Failures:

  1) CSV export WiceGrid should export csv
     Failure/Error: expect(page).to have_content('ID;Title;Priority;Status;Project Name;')
       expected #has_content?("ID;Title;Priority;Status;Project Name;") to return true, got false
     # ./spec/features/csv_export_request_spec.rb:11:in `block (2 levels) in <top (required)>'

Finished in 1 minute 52.23 seconds (files took 5.64 seconds to load)
224 examples, 1 failure

Failed examples:

rspec ./spec/features/csv_export_request_spec.rb:9 # CSV export WiceGrid should export csv

This seems related to the CSV export, so I do think it is broken because of your changes. Could you please have a look at it again? I'm using ruby 2.6.5p114.

I have also installed ruby 2.6.5p114 and at the commit c7a9da2a70 (that is patricklindsay:master] I have 2 failures:

Failures:

  1) auto reloads 3 WiceGrid should filter by Due Date independantly
     Failure/Error: expect(page).to have_content('2013-01-26')
       expected #has_content?("2013-01-26") to return true, got false
     # ./spec/features/auto_reloads3_request_spec.rb:100:in `block (3 levels) in <top (required)>'
     # /usr/local/rvm/gems/ruby-2.6.5@github/gems/capybara-3.13.2/lib/capybara/session.rb:344:in `within'
     # /usr/local/rvm/gems/ruby-2.6.5@github/gems/capybara-3.13.2/lib/capybara/dsl.rb:51:in `block (2 levels) in <module:DSL>'
     # /usr/local/rvm/gems/ruby-2.6.5@github/gems/capybara-3.13.2/lib/capybara/rspec/matcher_proxies.rb:15:in `within'
     # ./spec/features/auto_reloads3_request_spec.rb:99:in `block (2 levels) in <top (required)>'

  2) CSV export WiceGrid should export csv
     Failure/Error: expect(page).to have_content('ID;Title;Priority;Status;Project Name;')
       expected #has_content?("ID;Title;Priority;Status;Project Name;") to return true, got false
     # ./spec/features/csv_export_request_spec.rb:11:in `block (2 levels) in <top (required)>'

Finished in 12.96 seconds (files took 2.93 seconds to load)
2 examples, 2 failures

Failed examples:

rspec ./spec/features/auto_reloads3_request_spec.rb:74 # auto reloads 3 WiceGrid should filter by Due Date independantly
rspec ./spec/features/csv_export_request_spec.rb:9 # CSV export WiceGrid should export csv
dima4p commented 4 months ago

I close this PR, as I did not expect it to appear here.