search

patrickmarabeas / ng-FitText.js

An AngularJS directive for inflating web type.
http://patrickmarabeas.github.io/ng-FitText.js
MIT License
222 stars 61 forks source link

The behavior of Jade may prevent this module to work out of the box #47

Closed pmaoui closed 8 years ago

pmaoui commented 8 years ago

Hi, thank you for this module.

I had to investigate to understand why this module doesn't worked "out of the box". Just by adding data-fittext as a directive on my element.

It appears that Jade compiles data-fittext as data-fittext="data-fittext" in HTML in order to support older browser (they don't like empty attribute). I would suggest to use a specific attribute name for the compressor value instead of using the default directive attribute value.

It's not a big deal but Jade is quite popular and it will probably save some time to other people in the exact same situation :)

Regards,

dogancelik commented 8 years ago

:+1: for Jade support, since the project I'm working is using Jade too

case12 commented 8 years ago

I was able to get around this by doing inline tags in my jade file.

| <h1 data-fittext>This worked for me</h1>

or you can still do it in regular jade by using the compressor attribute. h1(data-fittext='1') This worked for me

patrickmarabeas commented 8 years ago

Eep, forgot about this issue sorry. Should be an easy fix by ensuring that the value is a number || 1.

patrickmarabeas commented 8 years ago

Fix has been published.