search

patrickmatte / scroll-capture

18 stars 5 forks source link

Console Error on click - currently unusable #25

Closed benjaminelwoods closed 10 months ago

benjaminelwoods commented 10 months ago

Console Errror

content.js:8 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'clone') at wt.deserialize (content.js:8:82065) at content.js:8:169411 deserialize @ content.js:8 (anonymous) @ content.js:8 Promise.then (async) startNextBranch @ content.js:8 start @ content.js:8 start @ content.js:8 _hideComplete @ content.js:8 tasksComplete @ content.js:8 start @ content.js:8 _startTransitions @ content.js:8 (anonymous) @ content.js:8 setTimeout (async) changeTheLocation @ content.js:8 set location @ content.js:8 (anonymous) @ content.js:8 (anonymous) @ content.js:8 (anonymous) @ content.js:8

patrickmatte commented 10 months ago

Thanks for the error log. I had to remove the JS action to be compatible with Chrome extension manifest V3. I'm wondering if this error could be caused by the extension reading the cookie and trying to rebuid the last list of actions which could include a JS action. Could you try to remove the extension and re-install it? That should clear the cookie. https://chrome.google.com/webstore/detail/scroll-capture/egmhoeaacclmanaimofoooiamhpkimkk/

benjaminelwoods commented 10 months ago

Re-installing it did the trick - any likelihood of the JS action being reinstated down the line?

patrickmatte commented 10 months ago

Unfortunately, the extension manifest v3 strictly prohibits the use of eval or new Function so it is impossible to execute a string of code that isn't part of the extension bundle. How were you using the JS action?

benjaminelwoods commented 10 months ago

Ah what a shame - all good!

I was actually using it to inject css before I recorded a video so that I could hide the scrollbar of the page and prevent my cursor from being recorded - among other things like hiding specific elements etc.

patrickmatte commented 10 months ago

Interesting. I could add options to hide the cursor and the scrollbar while recording. I could probably replace the old JS action with a CSS injection action.

benjaminelwoods commented 10 months ago

That would be fantastic!

patrickmatte commented 10 months ago

I pushed an update with toggles to hide the scroll bars and cursor in the settings. Let me know if you have other feature requests.

benjaminelwoods commented 10 months ago

Great stuff! Works a charm :) - The only thing would be CSS injection if you get around to it. But I'd be happy to let you know if I think of anything else 👍