patrickmccallum / mimetype-io

The code for mimetype.io
https://mimetype.io
MIT License
63 stars 13 forks source link

Fix RAR MIME type #2

Closed josantonius closed 1 year ago

josantonius commented 1 year ago

Great job!

I'll be utilizing mimeData.json within my own PHP library. I'll direct any change requests for this file to your repository, ensuring that only one version needs to be maintained.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mimetype-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 11:43pm
patrickmccallum commented 1 year ago

Thanks! I double checked the .rar mimetype and it looks like it's the other way around, with the application/vnd.rar being the "official" with application/x-rar-compressed being the deprecated one.

See https://www.iana.org/assignments/media-types/application/vnd.rar

There was a bug in the mimeData.json however where both types were marked as deprecated and so weren't showing in search.

If you'd like could you reset the mimeData.json to prioritise application/vnd.rar and add the above link for further reading to both of them and I'll merge it in. Thanks!

josantonius commented 1 year ago

Sorry, you're right! I finally enabled the wrong one 😅

I did not detect it on the web, it was in a test of my library that checks that there is always a non-deprecated option (because otherwise it would go into a loop).

I think it would be fine now

patrickmccallum commented 1 year ago

Ty for the contribution 😄