search

patrickmcelwee / ml-analytics-dashboard-ng

AngularJS analytics dashboard for use with MarkLogic database
Other
1 stars 1 forks source link

Abstract 'data source' away from individual charts #51

Closed patrickmcelwee closed 7 years ago

patrickmcelwee commented 7 years ago

This doesn't belong with each individual chart. There needs to be a hierarchy:

Report --has-many--> Data Sources Data Source --has-many--> Charts

And also, perhaps, a Dashboard that allows mixing and matching charts into a presentation.

The big question to me is at what point searchConstraints (search bar, faceting) should be introduced. It seems to make most sense at the Data Source, which will be defined by collection (or, as in the Optic API, by some other 'context'). Otherwise, search is likely to remove all results for some charts, but not others, making the experience disorienting for the user.

We might, therefore, consider making 'Data Source' and 'Report' synonymous. Or, at least, make a view onto a single Data Source the part that incorporates a rich search interface.

Also: does it make sense to allow individual charts to be embedded into a generic search page (this could also lead to the same disorienting experience described above)?

patrickmcelwee commented 7 years ago

The 'data source' was moved out of individual charts into the report itself by b6f073e8447bfd47b83ab98ca50d8a46969d8df8 and e4c1d2d69cc83fc1f6fdf1a6f9215325c8c50dca

This ticket is not yet finished, though, because data sources probably should be their own separate entity in the system. Right now, they are rather messily mixed up into the report itself.