search

patrickml / react-modal

Lightweight ReactJS Modal for MeteorJS
4 stars 0 forks source link

Failing to add in meteor 1.4 and crashed meteor 1.3 #6

Open Frazer opened 8 years ago

Frazer commented 8 years ago

Hi, I'm new to Meteor, but cant see a clear way forward on how to fix this:

meteor add patrickml:react-modal which then caused my running meteor instance to crash.

so I meteor remove patrickml:react-modal

and my app worked again. I thought updating might fix it running meteor update

when I then tried to add MODAL again, it failed to install: meteor add patrickml:react-modal

Detailed reports below:

meteor add patrickml:react-modal

Changes to your project's package version selections:

jsx added, version 0.2.4
patrickml:react-modal added, version 2.1.0 react added, version 0.2.1 react-runtime added, version 0.14.5

patrickml:react-modal: Lightweight ReactJS Modal

which then caused my running instance to crash:

Meteor 1.4.0.1 is available. Update this project with 'meteor update'.

/Users/me/.meteor/packages/less/.2.6.0.18upyx2++os+web.browser+web.cordova/plugin.compileLessBatch.os/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:116 throw error; ^ Error: ENOENT, readdir '/Users/me/.meteor/packages/npm-bcrypt/.0.8.5.1rez6l5++os.osx.x86_64+web.browser+web.cordova/npm/node_modules' Me:my-project me$ meteor --port 3321 [[[[[ ~/Code/Meteor/my-project ]]]]]

=> Started proxy.
=> Started MongoDB.
=> Meteor 1.4.0.1 is available. Update this project with 'meteor update'. W20160808-11:08:05.441(2)? (STDERR) WARNING: npm peer requirements not installed: W20160808-11:08:05.442(2)? (STDERR) - react@15.3.0 installed, react@0.14.x needed W20160808-11:08:05.443(2)? (STDERR) - react-dom@15.3.0 installed, react-dom@0.14.x needed W20160808-11:08:05.443(2)? (STDERR) - react-addons-transition-group@0.14.x not installed. W20160808-11:08:05.443(2)? (STDERR) - react-addons-css-transition-group@0.14.x not installed. W20160808-11:08:05.443(2)? (STDERR) - react-addons-linked-state-mixin@0.14.x not installed. W20160808-11:08:05.444(2)? (STDERR) - react-addons-create-fragment@0.14.x not installed. W20160808-11:08:05.444(2)? (STDERR) - react-addons-update@0.14.x not installed. W20160808-11:08:05.444(2)? (STDERR) - react-addons-pure-render-mixin@15.3.0 installed, react-addons-pure-render-mixin@0.14.x needed W20160808-11:08:05.444(2)? (STDERR) - react-addons-test-utils@0.14.x not installed. W20160808-11:08:05.444(2)? (STDERR) - react-addons-perf@0.14.x not installed. W20160808-11:08:05.444(2)? (STDERR) W20160808-11:08:05.445(2)? (STDERR) Read more about installing npm peer dependencies: W20160808-11:08:05.445(2)? (STDERR) http://guide.meteor.com/using-packages.html#peer-npm-dependencies W20160808-11:08:05.445(2)? (STDERR) => Exited with code: 8 W20160808-11:08:05.654(2)? (STDERR) W20160808-11:08:05.655(2)? (STDERR) /Users/me/.meteor/packages/meteor-tool/.1.3.2_4.ntqgyj++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:267 W20160808-11:08:05.655(2)? (STDERR) throw(ex); W20160808-11:08:05.655(2)? (STDERR) ^ W20160808-11:08:05.655(2)? (STDERR) Error: Can't find npm module 'react-addons-transition-group'. Did you forget to call 'Npm.depends' in package.js within the 'modules-runtime' package? W20160808-11:08:05.655(2)? (STDERR) at Object.Npm.require (/Users/me/Code/Meteor/my-project/.meteor/local/build/programs/server/boot.js:195:17) W20160808-11:08:05.655(2)? (STDERR) at options.fallback (packages/modules-runtime/modules-runtime.js:21:1) W20160808-11:08:05.655(2)? (STDERR) at require (packages/modules-runtime/.npm/package/node_modules/install/install.js:81:1) W20160808-11:08:05.656(2)? (STDERR) at meteorInstall.node_modules.meteor.react-runtime.react-runtime.js (packages/react-runtime/react-runtime.js:29:20) W20160808-11:08:05.656(2)? (STDERR) at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:141:1) W20160808-11:08:05.656(2)? (STDERR) at require (packages/modules-runtime/.npm/package/node_modules/install/install.js:75:1) W20160808-11:08:05.656(2)? (STDERR) at /Users/me/Code/Meteor/my-project/.meteor/local/build/programs/server/packages/react-runtime.js:86:15 W20160808-11:08:05.656(2)? (STDERR) at /Users/me/Code/Meteor/my-project/.meteor/local/build/programs/server/packages/react-runtime.js:99:3 W20160808-11:08:05.656(2)? (STDERR) at /Users/me/Code/Meteor/my-project/.meteor/local/build/programs/server/boot.js:283:10 W20160808-11:08:05.657(2)? (STDERR) at Array.forEach (native) W20160808-11:08:09.585(2)? (STDERR) WARNING: npm peer requirements not installed: W20160808-11:08:09.586(2)? (STDERR) - react@15.3.0 installed, react@0.14.x needed W20160808-11:08:09.586(2)? (STDERR) - react-dom@15.3.0 installed, react-dom@0.14.x needed W20160808-11:08:09.586(2)? (STDERR) - react-addons-transition-group@0.14.x not installed. W20160808-11:08:09.586(2)? (STDERR) - react-addons-css-transition-group@0.14.x not installed. W20160808-11:08:09.586(2)? (STDERR) - react-addons-linked-state-mixin@0.14.x not installed. W20160808-11:08:09.586(2)? (STDERR) - react-addons-create-fragment@0.14.x not installed. W20160808-11:08:09.587(2)? (STDERR) - react-addons-update@0.14.x not installed. W20160808-11:08:09.587(2)? (STDERR) - react-addons-pure-render-mixin@15.3.0 installed, react-addons-pure-render-mixin@0.14.x needed W20160808-11:08:09.587(2)? (STDERR) - react-addons-test-utils@0.14.x not installed. W20160808-11:08:09.587(2)? (STDERR) - react-addons-perf@0.14.x not installed. W20160808-11:08:09.587(2)? (STDERR) W20160808-11:08:09.587(2)? (STDERR) Read more about installing npm peer dependencies: W20160808-11:08:09.588(2)? (STDERR) http://guide.meteor.com/using-packages.html#peer-npm-dependencies W20160808-11:08:09.588(2)? (STDERR) W20160808-11:08:09.782(2)? (STDERR) W20160808-11:08:09.782(2)? (STDERR) /Users/me/.meteor/packages/meteor-tool/.1.3.2_4.ntqgyj++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:267 W20160808-11:08:09.782(2)? (STDERR) throw(ex); W20160808-11:08:09.783(2)? (STDERR) ^ W20160808-11:08:09.796(2)? (STDERR) Error: Can't find npm module 'react-addons-transition-group'. Did you forget to call 'Npm.depends' in package.js within the 'modules-runtime' package? W20160808-11:08:09.796(2)? (STDERR) at Object.Npm.require (/Users/me/Code/Meteor/my-project/.meteor/local/build/programs/server/boot.js:195:17) W20160808-11:08:09.797(2)? (STDERR) at options.fallback (packages/modules-runtime/modules-runtime.js:21:1) W20160808-11:08:09.797(2)? (STDERR) at require (packages/modules-runtime/.npm/package/node_modules/install/install.js:81:1) W20160808-11:08:09.797(2)? (STDERR) at meteorInstall.node_modules.meteor.react-runtime.react-runtime.js (packages/react-runtime/react-runtime.js:29:20) W20160808-11:08:09.797(2)? (STDERR) at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:141:1) W20160808-11:08:09.797(2)? (STDERR) at require (packages/modules-runtime/.npm/package/node_modules/install/install.js:75:1) W20160808-11:08:09.798(2)? (STDERR) at /Users/me/Code/Meteor/my-project/.meteor/local/build/programs/server/packages/react-runtime.js:86:15 W20160808-11:08:09.798(2)? (STDERR) at /Users/me/Code/Meteor/my-project/.meteor/local/build/programs/server/packages/react-runtime.js:99:3 W20160808-11:08:09.798(2)? (STDERR) at /Users/me/Code/Meteor/my-project/.meteor/local/build/programs/server/boot.js:283:10 W20160808-11:08:09.798(2)? (STDERR) at Array.forEach (native) => Exited with code: 8 W20160808-11:08:13.326(2)? (STDERR) WARNING: npm peer requirements not installed: W20160808-11:08:13.326(2)? (STDERR) - react@15.3.0 installed, react@0.14.x needed W20160808-11:08:13.326(2)? (STDERR) - react-dom@15.3.0 installed, react-dom@0.14.x needed W20160808-11:08:13.326(2)? (STDERR) - react-addons-transition-group@0.14.x not installed. W20160808-11:08:13.326(2)? (STDERR) - react-addons-css-transition-group@0.14.x not installed. W20160808-11:08:13.326(2)? (STDERR) - react-addons-linked-state-mixin@0.14.x not installed. W20160808-11:08:13.327(2)? (STDERR) - react-addons-create-fragment@0.14.x not installed. W20160808-11:08:13.327(2)? (STDERR) - react-addons-update@0.14.x not installed. W20160808-11:08:13.327(2)? (STDERR) - react-addons-pure-render-mixin@15.3.0 installed, react-addons-pure-render-mixin@0.14.x needed W20160808-11:08:13.327(2)? (STDERR) - react-addons-test-utils@0.14.x not installed. W20160808-11:08:13.327(2)? (STDERR) - react-addons-perf@0.14.x not installed. W20160808-11:08:13.327(2)? (STDERR) W20160808-11:08:13.327(2)? (STDERR) Read more about installing npm peer dependencies: W20160808-11:08:13.328(2)? (STDERR) http://guide.meteor.com/using-packages.html#peer-npm-dependencies W20160808-11:08:13.328(2)? (STDERR) W20160808-11:08:13.486(2)? (STDERR) W20160808-11:08:13.487(2)? (STDERR) /Users/me/.meteor/packages/meteor-tool/.1.3.2_4.ntqgyj++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:267 W20160808-11:08:13.487(2)? (STDERR) throw(ex); W20160808-11:08:13.487(2)? (STDERR) ^ W20160808-11:08:13.499(2)? (STDERR) Error: Can't find npm module 'react-addons-transition-group'. Did you forget to call 'Npm.depends' in package.js within the 'modules-runtime' package? W20160808-11:08:13.500(2)? (STDERR) at Object.Npm.require (/Users/me/Code/Meteor/my-project/.meteor/local/build/programs/server/boot.js:195:17) W20160808-11:08:13.500(2)? (STDERR) at options.fallback (packages/modules-runtime/modules-runtime.js:21:1) W20160808-11:08:13.500(2)? (STDERR) at require (packages/modules-runtime/.npm/package/node_modules/install/install.js:81:1) W20160808-11:08:13.500(2)? (STDERR) at meteorInstall.node_modules.meteor.react-runtime.react-runtime.js (packages/react-runtime/react-runtime.js:29:20) W20160808-11:08:13.500(2)? (STDERR) at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:141:1) W20160808-11:08:13.500(2)? (STDERR) at require (packages/modules-runtime/.npm/package/node_modules/install/install.js:75:1) W20160808-11:08:13.501(2)? (STDERR) at /Users/me/Code/Meteor/my-project/.meteor/local/build/programs/server/packages/react-runtime.js:86:15 W20160808-11:08:13.501(2)? (STDERR) at /Users/me/Code/Meteor/my-project/.meteor/local/build/programs/server/packages/react-runtime.js:99:3 W20160808-11:08:13.501(2)? (STDERR) at /Users/me/Code/Meteor/my-project/.meteor/local/build/programs/server/boot.js:283:10 W20160808-11:08:13.501(2)? (STDERR) at Array.forEach (native) => Exited with code: 8 => Your application is crashing. Waiting for file change.

so I meteor remove patrickml:react-modal

Changes to your project's package version selections:

jsx removed from your project patrickml:react-modal removed from your project react removed from your project react-runtime removed from your project

patrickml:react-modal: removed dependency

and my app worked again. I thought updating might fix it

meteor update

Changes to your project's package version selections from updating the release:

accounts-base upgraded from 1.2.7 to 1.2.9 accounts-password upgraded from 1.1.8 to 1.2.12 allow-deny upgraded from 1.0.4 to 1.0.5 babel-compiler upgraded from 6.6.4 to 6.9.0 babel-runtime upgraded from 0.1.8 to 0.1.10 base64 upgraded from 1.0.8 to 1.0.9 binary-heap upgraded from 1.0.8 to 1.0.9 blaze upgraded from 2.1.7 to 2.1.8 blaze-tools upgraded from 1.0.8 to 1.0.9 boilerplate-generator upgraded from 1.0.8 to 1.0.9 callback-hook upgraded from 1.0.8 to 1.0.9 check upgraded from 1.2.1 to 1.2.3 ddp-rate-limiter upgraded from 1.0.4 to 1.0.5 diff-sequence upgraded from 1.0.5 to 1.0.6 ecmascript upgraded from 0.4.3 to 0.5.7 ecmascript-runtime upgraded from 0.2.10 to 0.3.12 ejson upgraded from 1.0.11 to 1.0.12 email upgraded from 1.0.12 to 1.1.16 es5-shim upgraded from 4.5.10 to 4.6.13 geojson-utils upgraded from 1.0.8 to 1.0.9 html-tools upgraded from 1.0.9 to 1.0.10 htmljs upgraded from 1.0.9 to 1.0.10 id-map upgraded from 1.0.7 to 1.0.8 jquery upgraded from 1.11.8 to 1.11.9 localstorage upgraded from 1.0.9 to 1.0.11 logging upgraded from 1.0.12 to 1.1.14 meteor upgraded from 1.1.14 to 1.2.16 minifier-css upgraded from 1.1.11 to 1.2.13 minifier-js upgraded from 1.1.11 to 1.2.13 minimongo upgraded from 1.0.16 to 1.0.17 modules upgraded from 0.6.1 to 0.7.5 modules-runtime upgraded from 0.6.3 to 0.7.5 mongo upgraded from 1.1.7 to 1.1.10 mongo-id upgraded from 1.0.4 to 1.0.5 npm-bcrypt upgraded from 0.8.5 to 0.8.7 npm-mongo upgraded from 1.4.43 to 1.5.45 observe-sequence upgraded from 1.0.11 to 1.0.12 ordered-dict upgraded from 1.0.7 to 1.0.8 promise upgraded from 0.6.7 to 0.8.3 random upgraded from 1.0.9 to 1.0.10 rate-limit upgraded from 1.0.4 to 1.0.5 reactive-var upgraded from 1.0.9 to 1.0.10 routepolicy upgraded from 1.0.10 to 1.0.11 service-configuration upgraded from 1.0.9 to 1.0.10 sha upgraded from 1.0.7 to 1.0.8 spacebars upgraded from 1.0.11 to 1.0.12 spacebars-compiler upgraded from 1.0.11 to 1.0.12 srp upgraded from 1.0.8 to 1.0.9 standard-minifier-css upgraded from 1.0.6 to 1.1.8 standard-minifier-js upgraded from 1.0.6 to 1.1.8 tracker upgraded from 1.0.13 to 1.1.0 underscore upgraded from 1.0.8 to 1.0.9 webapp upgraded from 1.2.8 to 1.3.10

my-project: updated to Meteor 1.4.0.1.

Changes to your project's package version selections from updating package versions:

autoupdate upgraded from 1.2.9 to 1.2.11 caching-compiler upgraded from 1.0.4 to 1.0.6 ddp-client upgraded from 1.2.7 to 1.2.9 ddp-common upgraded from 1.2.5 to 1.2.6 ddp-server upgraded from 1.2.6 to 1.2.10 fastclick upgraded from 1.0.11 to 1.0.12 http upgraded from 1.1.5 to 1.1.8 launch-screen upgraded from 1.0.11 to 1.0.12 less upgraded from 2.6.0 to 2.6.5 practicalmeteor:mocha upgraded from 2.4.5_2 to 2.4.5_6 practicalmeteor:mocha-core* upgraded from 0.1.4 to 1.0.1 reactive-dict upgraded from 1.1.7 to 1.1.8 reload upgraded from 1.1.8 to 1.1.10 retry upgraded from 1.0.7 to 1.0.8 session upgraded from 1.1.5 to 1.1.6 templating upgraded from 1.1.9 to 1.1.14 url upgraded from 1.0.9 to 1.0.10

  • These packages have been updated to new versions that are not backwards compatible.

Newer versions of the following indirect dependencies are available:

  • autoupdate 1.2.11 (1.3.11 is available)
  • caching-compiler 1.0.6 (1.1.6 is available)
  • coffeescript 1.0.17 (1.2.3 is available)
  • ddp-client 1.2.9 (1.3.0 is available)
  • ddp-server 1.2.10 (1.3.9 is available)
  • http 1.1.8 (1.2.8 is available)
  • less 2.6.5 (2.7.4 is available)
  • templating 1.1.14 (1.2.13 is available)
    To update one or more of these packages, pass their names to meteor update.

note:

-METEOR@1.3.2.4 +METEOR@1.4.0.1

when I then tried to add MODAL again, it failed:

meteor add patrickml:react-modal

=> Errors while adding packages:

While downloading fourseven:scss@3.4.3...: error: Command failed: /Users/me/.meteor/packages/meteor-tool/.1.4.0-1.e8gar3++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/bin/npm rebuild --no-bin-links --update-binary module.js:327 throw err; ^

Error: Cannot find module '../' at Function.Module._resolveFilename (module.js:325:15) at Function.Module._load (module.js:276:25) at Module.require (module.js:353:17) at require (internal/module.js:12:17) at Object. (/private/var/folders/33/2qd0wv3d5sb3qzbsk2d8p3340000gn/T/mt-hcs0wj/plugin.compileScssBatch.os.osx.x86_64/npm/node_modules/meteor/compileScssBatch/node_modules/.temp-goptt9/node_modules/node-sass/node_modules/cross-spawn/node_modules/spawn-sync/node_modules/try-thread-sleep/node_modules/thread-sleep/node_modules/.bin/node-pre-gyp:15:20) at Module._compile (module.js:409:26) at Object.Module._extensions..js (module.js:416:10) at Module.load (module.js:343:32) at Function.Module._load (module.js:300:12) at Function.Module.runMain (module.js:441:10)

npm ERR! Darwin 15.5.0 npm ERR! argv "/Users/me/.meteor/packages/meteor-tool/.1.4.0-1.e8gar3++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/bin/node" "/Users/me/.meteor/packages/meteor-tool/.1.4.0-1.e8gar3++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/bin/npm" "rebuild" "--no-bin-links" "--update-binary" npm ERR! node v4.4.7 npm ERR! npm v3.10.5 npm ERR! code ELIFECYCLE npm ERR! thread-sleep@1.0.4 install: node-pre-gyp install --fallback-to-build npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the thread-sleep@1.0.4 install script 'node-pre-gyp install --fallback-to-build'. npm ERR! Make sure you have the latest version of node.js and npm installed. npm ERR! If you do, this is most likely a problem with the thread-sleep package, npm ERR! not with npm itself. npm ERR! Tell the author that this fails on your system: npm ERR! node-pre-gyp install --fallback-to-build npm ERR! You can get information on how to open an issue for this project with: npm ERR! npm bugs thread-sleep npm ERR! Or if that isn't available, you can get their info via: npm ERR! npm owner ls thread-sleep npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request: npm ERR! /private/var/folders/33/2qd0wv3d5sb3qzbsk2d8p3340000gn/T/mt-hcs0wj/plugin.compileScssBatch.os.osx.x86_64/npm/node_modules/meteor/compileScssBatch/node_modules/.temp-goptt9/npm-debug.log module.js:327 throw err; ^

Error: Cannot find module '../' at Function.Module._resolveFilename (module.js:325:15) at Function.Module._load (module.js:276:25) at Module.require (module.js:353:17) at require (internal/module.js:12:17) at Object. (/private/var/folders/33/2qd0wv3d5sb3qzbsk2d8p3340000gn/T/mt-hcs0wj/plugin.compileScssBatch.os.osx.x86_64/npm/node_modules/meteor/compileScssBatch/node_modules/.temp-goptt9/node_modules/node-sass/node_modules/cross-spawn/node_modules/spawn-sync/node_modules/try-thread-sleep/node_modules/thread-sleep/node_modules/.bin/node-pre-gyp:15:20) at Module._compile (module.js:409:26) at Object.Module._extensions..js (module.js:416:10) at Module.load (module.js:343:32) at Function.Module._load (module.js:300:12) at Function.Module.runMain (module.js:441:10)

npm ERR! Darwin 15.5.0 npm ERR! argv "/Users/me/.meteor/packages/meteor-tool/.1.4.0-1.e8gar3++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/bin/node" "/Users/me/.meteor/packages/meteor-tool/.1.4.0-1.e8gar3++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/bin/npm" "rebuild" "--no-bin-links" "--update-binary" npm ERR! node v4.4.7 npm ERR! npm v3.10.5 npm ERR! code ELIFECYCLE npm ERR! thread-sleep@1.0.4 install: node-pre-gyp install --fallback-to-build npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the thread-sleep@1.0.4 install script 'node-pre-gyp install --fallback-to-build'. npm ERR! Make sure you have the latest version of node.js and npm installed. npm ERR! If you do, this is most likely a problem with the thread-sleep package, npm ERR! not with npm itself. npm ERR! Tell the author that this fails on your system: npm ERR! node-pre-gyp install --fallback-to-build npm ERR! You can get information on how to open an issue for this project with: npm ERR! npm bugs thread-sleep npm ERR! Or if that isn't available, you can get their info via: npm ERR! npm owner ls thread-sleep npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request: npm ERR! /private/var/folders/33/2qd0wv3d5sb3qzbsk2d8p3340000gn/T/mt-hcs0wj/plugin.compileScssBatch.os.osx.x86_64/npm/node_modules/meteor/compileScssBatch/node_modules/.temp-goptt9/npm-debug.log

Any suggestions?

patrickml commented 8 years ago

Hey Sorry this Repo is really outdated doc wise. I need to update them.

It looks like the repo has a requirement for an older version of react which needs to be updated/removed.

For now if you went to the lib dir you could just copy the repo source code

https://github.com/patrickml/react-modal/tree/master/lib

patrickml commented 8 years ago

Also it looks like you need to do npm install --save react-addons-transition-group

Frazer commented 8 years ago

Oh, I found a work around from https://forums.meteor.com/t/fourseven-scss-meteor-1-4-error-cant-install-mac-ox/27129/2

mv .meteor/versions .meteor/old.versions
touch .meteor/versions
meteor reset
meteor update

then
meteor add fourseven:scss then meteor add patrickml:react-modal

It installed succesfully. Now I'll see if I can use it in my project 🎱

Frazer commented 8 years ago

oh wait. it still crashes my app. So, that fix allows it to install, but I got this crash message

W20160809-11:44:32.859(2)? (STDERR) /Users/frazerkirkman/.meteor/packages/meteor-tool/.1.4.0-1.e8gar3++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:280 W20160809-11:44:32.929(2)? (STDERR) throw(ex); W20160809-11:44:32.930(2)? (STDERR) ^ W20160809-11:44:32.931(2)? (STDERR) W20160809-11:44:32.931(2)? (STDERR) Error: Can't find npm module 'react-addons-css-transition-group'. Did you forget to call 'Npm.depends' in package.js within the 'modules-runtime' package? W20160809-11:44:32.931(2)? (STDERR) at Object.Npm.require (/Users/frazerkirkman/Code/Meteor/meme-trainer/.meteor/local/build/programs/server/boot.js:203:17) W20160809-11:44:32.932(2)? (STDERR) at options.fallback (packages/modules-runtime/modules-runtime.js:21:1) W20160809-11:44:32.933(2)? (STDERR) at Module.require (packages/modules-runtime/.npm/package/node_modules/install/install.js:88:1) W20160809-11:44:32.933(2)? (STDERR) at Module.Mp.import (/Users/frazerkirkman/.meteor/packages/modules/.0.7.5.16wlehk++os+web.browser+web.cordova/npm/node_modules/reify/lib/runtime.js:70:16) W20160809-11:44:32.933(2)? (STDERR) at meteorInstall.node_modules.meteor.patrickml:react-modal.lib.react-modal.jsx (/Users/frazerkirkman/Code/Meteor/meme-trainer/.meteor/local/build/programs/server/packages/patrickml_react-modal.js:86:252) W20160809-11:44:32.934(2)? (STDERR) at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:153:1) W20160809-11:44:32.934(2)? (STDERR) at Module.require (packages/modules-runtime/.npm/package/node_modules/install/install.js:82:1) W20160809-11:44:32.935(2)? (STDERR) at Module.Mp.import (/Users/frazerkirkman/.meteor/packages/modules/.0.7.5.16wlehk++os+web.browser+web.cordova/npm/node_modules/reify/lib/runtime.js:70:16) W20160809-11:44:32.935(2)? (STDERR) at meteorInstall.node_modules.meteor.patrickml:react-modal.entry.js (packages/patrickml:react-modal/entry.js:1:1) W20160809-11:44:32.935(2)? (STDERR) at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:153:1) => Exited with code: 1 W20160809-11:44:39.637(2)? (STDERR) /Users/frazerkirkman/.meteor/packages/meteor-tool/.1.4.0-1.e8gar3++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:280 W20160809-11:44:39.639(2)? (STDERR) throw(ex); W20160809-11:44:39.639(2)? (STDERR) ^ W20160809-11:44:39.640(2)? (STDERR) W20160809-11:44:39.640(2)? (STDERR) Error: Can't find npm module 'react-addons-css-transition-group'. Did you forget to call 'Npm.depends' in package.js within the 'modules-runtime' package? W20160809-11:44:39.640(2)? (STDERR) at Object.Npm.require (/Users/frazerkirkman/Code/Meteor/meme-trainer/.meteor/local/build/programs/server/boot.js:203:17) W20160809-11:44:39.640(2)? (STDERR) at options.fallback (packages/modules-runtime/modules-runtime.js:21:1) W20160809-11:44:39.640(2)? (STDERR) at Module.require (packages/modules-runtime/.npm/package/node_modules/install/install.js:88:1) W20160809-11:44:39.641(2)? (STDERR) at Module.Mp.import (/Users/frazerkirkman/.meteor/packages/modules/.0.7.5.16wlehk++os+web.browser+web.cordova/npm/node_modules/reify/lib/runtime.js:70:16) W20160809-11:44:39.641(2)? (STDERR) at meteorInstall.node_modules.meteor.patrickml:react-modal.lib.react-modal.jsx (/Users/frazerkirkman/Code/Meteor/meme-trainer/.meteor/local/build/programs/server/packages/patrickml_react-modal.js:86:252) W20160809-11:44:39.642(2)? (STDERR) at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:153:1) W20160809-11:44:39.642(2)? (STDERR) at Module.require (packages/modules-runtime/.npm/package/node_modules/install/install.js:82:1) W20160809-11:44:39.642(2)? (STDERR) at Module.Mp.import (/Users/frazerkirkman/.meteor/packages/modules/.0.7.5.16wlehk++os+web.browser+web.cordova/npm/node_modules/reify/lib/runtime.js:70:16) W20160809-11:44:39.643(2)? (STDERR) at meteorInstall.node_modules.meteor.patrickml:react-modal.entry.js (packages/patrickml:react-modal/entry.js:1:1) W20160809-11:44:39.644(2)? (STDERR) at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:153:1) => Exited with code: 1 W20160809-11:44:45.403(2)? (STDERR) /Users/frazerkirkman/.meteor/packages/meteor-tool/.1.4.0-1.e8gar3++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:280 W20160809-11:44:45.404(2)? (STDERR) throw(ex); W20160809-11:44:45.405(2)? (STDERR) ^ W20160809-11:44:45.406(2)? (STDERR) W20160809-11:44:45.408(2)? (STDERR) Error: Can't find npm module 'react-addons-css-transition-group'. Did you forget to call 'Npm.depends' in package.js within the 'modules-runtime' package? W20160809-11:44:45.408(2)? (STDERR) at Object.Npm.require (/Users/frazerkirkman/Code/Meteor/meme-trainer/.meteor/local/build/programs/server/boot.js:203:17) W20160809-11:44:45.409(2)? (STDERR) at options.fallback (packages/modules-runtime/modules-runtime.js:21:1) W20160809-11:44:45.409(2)? (STDERR) at Module.require (packages/modules-runtime/.npm/package/node_modules/install/install.js:88:1) W20160809-11:44:45.410(2)? (STDERR) at Module.Mp.import (/Users/frazerkirkman/.meteor/packages/modules/.0.7.5.16wlehk++os+web.browser+web.cordova/npm/node_modules/reify/lib/runtime.js:70:16) W20160809-11:44:45.410(2)? (STDERR) at meteorInstall.node_modules.meteor.patrickml:react-modal.lib.react-modal.jsx (/Users/frazerkirkman/Code/Meteor/meme-trainer/.meteor/local/build/programs/server/packages/patrickml_react-modal.js:86:252) W20160809-11:44:45.411(2)? (STDERR) at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:153:1) W20160809-11:44:45.412(2)? (STDERR) at Module.require (packages/modules-runtime/.npm/package/node_modules/install/install.js:82:1) W20160809-11:44:45.412(2)? (STDERR) at Module.Mp.import (/Users/frazerkirkman/.meteor/packages/modules/.0.7.5.16wlehk++os+web.browser+web.cordova/npm/node_modules/reify/lib/runtime.js:70:16) W20160809-11:44:45.413(2)? (STDERR) at meteorInstall.node_modules.meteor.patrickml:react-modal.entry.js (packages/patrickml:react-modal/entry.js:1:1) W20160809-11:44:45.414(2)? (STDERR) at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:153:1) => Exited with code: 1

I'll try just using the code as you suggested. Thanks :)

Frazer commented 8 years ago

how on earth does mixins : [ReactModalMixin] work?

I assume it 'imports' react-modal-component.jsx, but I cant work out how, and my meteor program cant do it either.

I copied your lib files in to my app, imported them, but then as soon as I add
to my app render function, then the app stopped working

ReferenceError: ReactModalMixin is not defined at meteorInstall.lib.jsx.EnclosedModal.jsx (lib/jsx/EnclosedModal.jsx:5:13)

Frazer commented 8 years ago

I managed to get it working for meteor 1.4

https://github.com/Frazer/react-modal/

however, I'm not sure if your mixins or this.shouldComponentUpdate = PureRenderMixin.shouldComponentUpdate.bind(this); do anything.

Frazer commented 8 years ago

Any feedback? And I think I'll turn it in to a npm package - your thoughts?

patrickml commented 8 years ago

@Frazer glad to hear it! I would love to get PR if possible. As for the PureRenderMixin the React Docs show to use like so for es6 classes this.shouldComponentUpdate = PureRenderMixin.shouldComponentUpdate.bind(this);

https://facebook.github.io/react/docs/pure-render-mixin.html

The reason for adding the shouldComponentUpdate was in case you inline the modal in a stateful component the modal won't constantly re-render unless the props like isOpen are changed.

Personally, I have changed the architecture of my app to have one single modal that injects children into the modal from a component registry so the shouldComponentUpdate doesn't make much of a difference for myself.

patrickml commented 8 years ago

Oh yes an npm package would be much better On Tue, Aug 9, 2016 at 5:46 PM Frazer Kirkman notifications@github.com wrote:

Any feedback? And I think I'll turn it in to a npm package - your thoughts?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/patrickml/react-modal/issues/6#issuecomment-238702167, or mute the thread https://github.com/notifications/unsubscribe-auth/AHOuuauX6qGeI29IajEuPNvRaDZZjIcqks5qePUzgaJpZM4JfV_- .

Frazer commented 8 years ago

Hey, I just figured out PR meant pull request... how would that work if the code is totally different now?

patrickml commented 8 years ago

ah you didn't fork the repo did you. Are you going to support your version? If so i can just tell everyone to add your version instead.

Frazer commented 8 years ago

I guess I'll support it. Not sure what that means exactly. I'll update it as I develop it.

Birk Skyum on the meteor forums suggested 'It would probably be better to polish reactjs/react-modal and send a pr.'