search

patricknelson / svelte-retag

Light DOM custom element wrapper for Svelte 3 and 4 with slots, context and Vite HMR support
https://www.npmjs.com/package/svelte-retag
MIT License
39 stars 0 forks source link

feat: fix types #40

Closed baseplate-admin closed 9 months ago

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-retag ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 4:20pm
patricknelson commented 9 months ago

Ah, interesting. So, it looks like all you need is this combined with the PR #33 and that resolves it for you?

patricknelson commented 9 months ago

Checked out your branch and ran the build (i.e. tsc --emiteDeclarationOnly) and this import() syntax you used here seems to work well. 🙂

I'll comment on the code inline however since I do have one outstanding question.

patricknelson commented 9 months ago

Will likely close this PR depending on feedback based on comment at https://github.com/patricknelson/svelte-retag/pull/33#issuecomment-1843789833