patrickpollet / mahara_plugin_auth_cas

3 stars 10 forks source link

Updates for compatibility with Mahara 1.8 #4

Closed agwells closed 10 years ago

agwells commented 10 years ago
agwells commented 10 years ago

Hi Patrick,

Here are the changes I've written to make this plugin compatible with Mahara 1.8. In 1.8 we integrated the ldap sync cron into the LDAP plugin, so since this plugin inherits from LDAP, it needed couple of tweaks to make it compatible.

Unfortunately, this change also makes it incompatible with Mahara 1.7... or at least, the ldapsync cron task will attempt to run once a day and it will error out because the functions it calls aren't present. Also it will have a bunch of configuration options on the settings screen which won't do anything because the ldapsync cron isn't present. So you may want to make a 1.7_STABLE branch to continue maintaining the 1.7-compatible version.

Cheers, Aaron

patrickpollet commented 10 years ago

Ok I guess I did it right by creating a 1.7_stable branch and merging your changes to master (1.8). I alsoupdated a bit the README file.

Cheers