patrickrst / LUCA

LEGO Universe Creation (Lab) Archiver
GNU General Public License v3.0
1 stars 2 forks source link

LUCA v0.3 #2

Closed le717 closed 11 years ago

le717 commented 11 years ago
print("Begin Pull Request")

I got the prerequisites all working, and was able to finish the changes. While this is your program, and I don't want to write it myself (:stuck_out_tongue:), I made these changes to help you get a sure footing and can finish it before the Creation Lab is closed forever.

Consider this more of a code maintenance PR than a full-featured new release PR. Most of what I've done is fix up the code to follow Python standards and recommendations (see the new CHANGES file). However, I was able to fix a few bugs, namely:

Do note that the success message will display even if it failed, so you'll need to wrap the code in a try... except block. :wink:

Issue #1 is still present, as I wasn't going to touch your file download code (I have no idea how it works).

I saw your commit message about making the code smaller by shorting variable names. Doing that can actually hurt more than help. If your variables are so short and non-descriptive, you can get easily confused by them all and become unsure what everything means. But there is also something to be said about super long names.

If you fix that issue (and even if you don't), it could be ready for public usage, and any updates would be mostly refinements, but that is up to you.

There is no need to credit me in the Readme, unless you want to. I just did this to help you succeed. :wink:

print("End Pull Request")
patrickrst commented 11 years ago

Thanks for the help, le717! Going to merge this.

le717 commented 11 years ago

WAIT!

I was about to push one more commit, one that would improve the progress bar.

The files were displayed after the fact, after everything was downloaded.