search

patrickshox / Mojave-Dark-RStudio-Theme

A Total-IDE Dark RStudio Theme inspired by Apple's dark aestheticcc.
MIT License
250 stars 24 forks source link

Enhancement: make git "review changes" window dark #2

Closed hughjonesd closed 5 years ago

hughjonesd commented 5 years ago

When you hit "commit" in the git panel, you get a new window which is white. It would be nice if this was dark too.

patrickshox commented 5 years ago

Thanks for pointing that out. I just committed a version, which should style that. I don't use Git with RStudio so please lmk if something doesn't look right.

hughjonesd commented 5 years ago
image

It looks OK but with a couple of awkward bits in the history interface (dark blue text, one pale chunk).

LDalby commented 5 years ago

Thanks for this awesome theme! It's really nice!

In the git interface - Is it possible to also have the close button, frame and horizontal scroll bar dark?

image

patrickshox commented 5 years ago

I'll try. But it'll be a few days as I have homework due tomorrow.

LDalby commented 5 years ago

Of course, no hurry!

Thanks again for the effort with this theme 👍

patrickshox commented 5 years ago

I've committed another version, which should be MUCH better. Please let me know over the next few days if y'all notice anything off. Otherwise, I'll close this issue thread.

LDalby commented 5 years ago

The "close" button is still white, but otherwise it looks great! image

LDalby commented 5 years ago

Ahh, I was a bit too fast. The horizontal scroll bar is actually still white, but the "close" button is now fixed 👍 I also noticed that the "Your branch is ahead..." info line (behind the Git Push window in the image) is on a white background. Perhaps that could be darkened too?

image