search

patricktalmadge / bootstrapper

Laravel Twitter Bootstrap Bundle
561 stars 129 forks source link

Remove autoroute check from dropdownShouldBeActive #268

Open ghost opened 9 years ago

ghost commented 9 years ago

The autoroute check was redundant. The check would also break functionality where the user is manually managing link active status and has autorouting disabled.

PatrickRose commented 9 years ago

Have you a test for that?

ghost commented 9 years ago

I don't have a test case for it. Let me try putting one together.

PatrickRose commented 9 years ago

Just spotted you've added another commit to this PR that for something else.

Could you split that one into a seperate PR? It's just helpful for cleaning things up.

PatrickRose commented 9 years ago

This has been left for a bit long - does it still apply?