search

patricktalmadge / bootstrapper

Laravel Twitter Bootstrap Bundle
561 stars 129 forks source link

Update to support Laravel 5.4 #321

Closed daryledesilva closed 7 years ago

daryledesilva commented 7 years ago
tortuetorche commented 7 years ago

Hi @daryledesilva,

Your pull-request break compatibilities with older versions of Laravel. See https://github.com/patricktalmadge/bootstrapper/pull/318 for a patch which is compatible with all versions of Laravel 5.*.

Cheers, Tortue Torche

daryledesilva commented 7 years ago

@tortuetorche Added. Thanks for the feedback!

tortuetorche commented 7 years ago

@daryledesilva Did you see my comment https://github.com/patricktalmadge/bootstrapper/pull/321#pullrequestreview-27898169 ?

daryledesilva commented 7 years ago

@tortuetorche okay doing now. will push commit in a few minutes

daryledesilva commented 7 years ago

@tortuetorche pushed changes. please check if this passes psr2 validation. thanks!

daryledesilva commented 7 years ago

thanks @PatrickRose !