search

patricktalmadge / bootstrapper

Laravel Twitter Bootstrap Bundle
561 stars 129 forks source link

fix issue #331 #334

Closed ghost closed 6 years ago

ghost commented 6 years ago

fix issue 331 already as should with a branch and all

PatrickRose commented 6 years ago

I don't think we should do this. Automatically registering our service provider makes sense. Demanding our aliases are used seems a bit much - how would you turn this off if you wanted a different alias? What happens if there's a conflict?

ghost commented 6 years ago

the client can turn it off adding this in the composer json: "extra": {  "laravel": { "dont-discover": [ "patricktalmadge/bootstrapper" ] } }, you can put this in the readme

PatrickRose commented 6 years ago

Doing that would mean that you'd lose the service provider and have to register that manually. I don't see a good argument for demanding our aliases are registered, but I do see an argument for registering our service provider.

You might not want to have all these aliases (most of the time you're going to just use the navbar, maybe the form), so I don't think we should demand that you use them. If people want to, they can just copy-paste the aliases dump that we have in the readme.

Thanks for your contribution though!