search

patricktalmadge / bootstrapper

Laravel Twitter Bootstrap Bundle
561 stars 129 forks source link

fixed method signature to be compatible with collective/html 5.5.2+ #335

Closed austenc closed 6 years ago

austenc commented 6 years ago

Hey there, due to the change here the method signature of select() changed slightly which is causing PHP errors in one of my projects.

https://github.com/LaravelCollective/html/commit/2c5db92f662bf5dfb7b198265168599941e29de6#diff-36caabaf080d6afdac600a28bfcd238bR588

This PR adds the extra parameter to fix this.

austenc commented 6 years ago

Any word on if we can get this merged?

kevinnio commented 6 years ago

I also need this merged as well since I'm having the same problem on a project.

kevinnio commented 6 years ago

@patricktalmadge just wanted to bring your attention to this PR

PatrickRose commented 6 years ago

I'm the main maintainer at the moment - I'll sort this out when I'm back from holiday

PatrickRose commented 6 years ago

Tagged!