search

patricktran / react-magic-slider-dots

React Magic Dots Component for React Slick Carousel (inspired by Instagram)
https://patricktran.github.io/react-magic-slider-dots/
26 stars 11 forks source link

Doesn't work completely with infinite set to true #2

Closed duongthienlee closed 5 years ago

duongthienlee commented 5 years ago

Thank for your great lib. It looks like react-magic-slider-dots doesn't handle infinite case. Any ideas to handle that case ?

patricktran commented 5 years ago

Hi there. Yes, the current version intends to mimic Instagram image galleries, where there is a start and end (not infinite). Hopefully, not supporting the infinite case isn't a deal breaker for you... I'll keep this in mind and will put on the 'Wish List' for a near future release.

patricktran commented 5 years ago

@duongthienlee v1.1.3 supports the infinite use case. Try it out!

duongthienlee commented 5 years ago

@patricktran. Thank for letting me know. Works like a charm !