search

patricktran / react-table-hoc-draggable-columns

ReactTable HOC for draggable columns
https://patricktran.github.io/react-table-hoc-draggable-columns/
MIT License
28 stars 24 forks source link

Drop place indicator doesn't match column drop place #1

Closed kibiukibis closed 5 years ago

kibiukibis commented 5 years ago

Hey @patricktran, thank you for this hoc. Helped a lot. But there is minor issue with drop and drop indicator mismatch on reorder mode. When dropping on first half of column indicator shows that it will be dropped before the column, but is dropped after column.

patricktran commented 5 years ago

Hmmm, I'm not seeing this behavior. Are you able to consistently reproduce on the demo page or do you have a codesandbox.io example?

kibiukibis commented 5 years ago

Yes I am able on demo page. Let's say drag "Vin" column in the first half of "Brand" column. Arrow appears before "Brand" column, but "Vin" is dropped after "Brand" column.

patricktran commented 5 years ago

https://github.com/patricktran/react-table-hoc-draggable-columns/commit/479f821370664602c6d9216f7e19dafc97cbfff9

Thanks for reporting this! Fixed in v 1.0.1

Please let me know if you encounter any other issues.