search

patricktran / react-table-hoc-draggable-columns

ReactTable HOC for draggable columns
https://patricktran.github.io/react-table-hoc-draggable-columns/
MIT License
28 stars 24 forks source link

Changing the actual draggable columns after first render, does not work. #24

Open ds-martinso opened 4 years ago

ds-martinso commented 4 years ago

On first render, passing in whatever columns that should be draggable works perfectly. It is possible to add columns to the draggable list.

However, it is not working when I remove a column from the draggable list. Even if it updates and rerenders, the removed column is still draggable. It will however respect the change on browser refresh.

When looking in the inspector, the column class div gets a "draggable=true", but when passing in an empty array for draggable, it does not remove the draggable=true attribute immediately. You have to reorder a column in order to refresh so that the attribute goes away. Do I have to make a full rerender myself?

How come it is like this?

patricktran commented 3 years ago

Hi @ds-martinso

I took a hiatus from supporting this package but I am now getting back into it. I will take a look at this issue and see if there is anything that can be done.

ds-martinso commented 3 years ago

Hi @patricktran Thanks for the reply, and great to see that you are back. I will be moving to react-table v7, so this library is no longer of use to me. But I hope this finding will be of use, and keep up with the great work!

patricktran commented 3 years ago

@ds-martinso Would you be able to provide a demo of what the issue is?

Feel free to create a fork of this: https://codesandbox.io/s/lucid-goodall-f8swq?file=/src/App.js