search

patrickzib / SFA

Scalable Time Series Data Analytics
GNU General Public License v3.0
309 stars 67 forks source link

README Inconsistent #31

Closed wwjd1234 closed 5 years ago

wwjd1234 commented 5 years ago

HI,

The code in the README seems to be different than how the usage is in the test cases. For example:

Score score = weasel.fit(trainSamples);
Score should be Classifier.Score

Is this correct? If so, should the README be updated?

patrickzib commented 5 years ago

Thank you for using Weasel. I am on vacation and will come back to you next week. Thanks

wwjd1234 commented 5 years ago

No problem thanks

Sent from my iPhone

On Aug 26, 2019, at 5:34 PM, Patrick Schäfer notifications@github.com wrote:

Thank you for using Weasel. I am on vacation and will come back to you next week. Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

patrickzib commented 5 years ago

Thank you for pointing this out. This was in fact wrong, I changed it to Classifier.Score, as you suggested.