patricmutwiri / mod-spdy

Automatically exported from code.google.com/p/mod-spdy
0 stars 0 forks source link

Unable to set the maximum concurrent streams #26

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What version/revision number of mod_spdy are you using?
r243

What version of Apache are you using, and on what operating system?  (Use
`apache2ctl -v` to check.)
2.2.22

What other Apache modules are you using?  (Use `apache2ctl -M` to check.)
 core_module (static)
 mpm_worker_module (static)
 http_module (static)
 so_module (static)
 spdy_module (shared)
 actions_module (shared)
 alias_module (shared)
 auth_basic_module (shared)
 authn_file_module (shared)
 authz_host_module (shared)
 authz_groupfile_module (shared)
 authz_default_module (shared)
 authz_user_module (shared)
 autoindex_module (shared)
 cgid_module (shared)
 dir_module (shared)
 env_module (shared)
 expires_module (shared)
 include_module (shared)
 log_config_module (shared)
 mime_module (shared)
 negotiation_module (shared)
 setenvif_module (shared)
 ssl_module (shared)
 userdir_module (shared)
 fcgid_module (shared)
 deflate_module (shared)
 rewrite_module (shared)
 proxy_module (shared)
 proxy_http_module (shared)
 proxy_balancer_module (shared)
 cache_module (shared)
 disk_cache_module (shared)
 ldap_module (shared)
 authnz_ldap_module (shared)

What browser version did you use to access the mod_spdy server?  On what
operating system? What flags was the browser invoked with?  (For
Chrome/Chromium, go to about:version to check.)
Chrome 18.0.23.1025.33

What steps will reproduce the problem?
1. Set:
 SpdyMaxStreamsPerConnection 100
2. With chrome:/net-internals you can check that the max streams is still 10

What is the expected result? What do you see instead?
max streams = 100

Please provide any additional information below.

Original issue reported on code.google.com by gronan.r...@gmail.com on 19 Feb 2012 at 2:41

GoogleCodeExporter commented 8 years ago
Ah, good catch; thanks for the report.

The stream limit you set is being enforced on the server-side (mod_spdy will 
send RST_STREAM with REFUSED_STREAM if the client tries to open too many 
streams at once, and the client will retry later), but mod_spdy isn't ever 
sending a SETTINGS frame to inform the client of the limit (which can lead to 
wasted frames as the client keeps retrying requests over and over, not knowing 
what the limit is).

It should be a simple fix for mod_spdy to just send a SETTINGS frame when the 
connection is first opened.  I'll let you know when that's done and checked in.

Original comment by mdste...@google.com on 21 Feb 2012 at 3:44

GoogleCodeExporter commented 8 years ago
Should be fixed in r247.  Let me know if it doesn't work for you.

Original comment by mdste...@google.com on 21 Feb 2012 at 4:27

GoogleCodeExporter commented 8 years ago
Works perfectly.
Thanks

Original comment by gronan.r...@gmail.com on 21 Feb 2012 at 5:44