patrikhuber / eos

A lightweight 3D Morphable Face Model library in modern C++
Apache License 2.0
1.89k stars 596 forks source link

convert-bfm2017-to-eos.py error #238

Closed viliusmat closed 5 years ago

viliusmat commented 5 years ago

Hello, I was trying to convert bjm2017 to eos format using provided script. But I got an error: File "convert-bfm2017-to-eos.py", line 48, in model = eos.morphablemodel.MorphableModel(shape_model, expression_model, color_model, []) # uv-coordinates can be added here TypeError: init(): incompatible constructor arguments...

It looks like that the problem is expression_model. Thank You for Your answer.

igriffer commented 5 years ago

Same error with demo.py. Tried with the pip version v0.18.0, self-compiled master, v1.0.0, v.0.18.0.

patrikhuber commented 5 years ago

@igriffer The error in demo.py should be fixed in 698a7d9147f1058c6c703c0b34a3ef773489bd39, committed yesterday. Did you try before or after that commit?

convert-bfm2017-to-eos.py can be "fixed" in exactly the same way. I might commit it if I find some time to change it but it's really trivial to just do locally in the meantime.

viliusmat commented 5 years ago

Thank you.

igriffer commented 5 years ago

It works, thanks! Can you tell when version 1.0.0 can be installed from pip?

patrikhuber commented 5 years ago

The BFM scripts should now work again too, see 001e0157004f55881d889346d75990e8bd06a191.

@igriffer "Soon" - I'll update this issue once I update pip. However in the meantime, you can still install eos with pip - git clone the repo and then do pip install .\eos on the source directory from GitHub, this will build and install it into pip :-) It's "just" one step more of cloning "manually".

patrikhuber commented 5 years ago

v1.0.1 is now on pypi!