Pass const-references to the save_*model() functions - Githubissues

patrikhuber / eos

A lightweight 3D Morphable Face Model library in modern C++

Apache License 2.0

1.89k stars 596 forks source link

Pass const-references to the save_*model() functions #244

Open patrikhuber opened 5 years ago

patrikhuber commented 5 years ago

I think here https://github.com/patrikhuber/eos/blob/f8b235bf8da1eef947a62dc09e23ecde2c9c0f3b/include/eos/morphablemodel/PcaModel.hpp#L348 and here https://github.com/patrikhuber/eos/blob/f8b235bf8da1eef947a62dc09e23ecde2c9c0f3b/include/eos/morphablemodel/MorphableModel.hpp#L546 we could just pass const& model, otherwise we make a copy of the model.