search

patrikhuber / eos

A lightweight 3D Morphable Face Model library in modern C++
Apache License 2.0
1.89k stars 596 forks source link

make v2 version of the texture extraction inline #269

Closed JBamberger closed 4 years ago

JBamberger commented 4 years ago

I've encountered a linker error after including the texture extraction header in multiple places. The problem seems to be that the v2 version of the extract_texture function is not inline. If this is intentional for some reason please correct me since I am quite new to C++.

patrikhuber commented 4 years ago

Hi, Thanks for the PR! Great spot, indeed the inline is missing there, and you'd get those linker errors. Could you clang-format the changed line please? There's a .clang-format at the root of the repo. And then this is good to go.

Cheers!

JBamberger commented 4 years ago

Hi, I've pushed the requested change.

patrikhuber commented 4 years ago

Awesome, thanks again.