search

patrikhuber / eos

A lightweight 3D Morphable Face Model library in modern C++
Apache License 2.0
1.89k stars 596 forks source link

Remove `affine_camera_estimation.hpp` #303

Closed patrikhuber closed 3 years ago

patrikhuber commented 4 years ago

The file affine_camera_estimation.hpp could be / should be removed - I can see that it still uses OpenCV, which has been removed as a dependency from eos a long time ago. I don't think this code is used anywhere anymore.

We should probably move the detailed comments and the reference from that file to eos/fitting/orthographic_camera_estimation_linear.hpp, which uses the same method to start off with.

patrikhuber commented 3 years ago

I removed that file in 507eb776d06ac47494b15c2b3bf702400ad429e1. Comments and references are also present in orthographic_camera_estimation_linear.hpp. One thing I noticed that is different is that the affine one normalised all the points, whereas in the newer orthographic implementation we seem to just use the given image and model points directly. I guess that's okay.