search

patrikhuber / eos

A lightweight 3D Morphable Face Model library in modern C++
Apache License 2.0
1.89k stars 596 forks source link

fix of strides on image cast for python bindings #316

Closed Sergio-shu closed 3 years ago

Sergio-shu commented 3 years ago

I used core::Image4u with python binding and found that it has wrong strides in cast function. Hope it will be helpful.

Best Regards, Sergei.

patrikhuber commented 3 years ago

Hi Sergei,

Thanks a lot for the PR! This is indeed true. I have fixed this a while ago in the devel branch, in dc0fce864caf87648ac116d8ca1b2cf55435b65a. It looks like your changes are exactly the same as mine, which is great. So I think I can close this, and I would recommend using the devel branch meanwhile.

I apologise that the master branch is in a bit of an "old" state, I shall try and find the time soon to finish cleaning up some things, merge devel into master and put out a new release.

Thank you again for your contribution!