search

patriknw / akka-data-replication

Replication of CRDTs in Akka Cluster
Other
216 stars 18 forks source link

Add type parameter for the element type #73

Closed patriknw closed 9 years ago

patriknw commented 9 years ago

@hseeberger @huntc what do you think about this PR? I have added a type parameter defining the type of the elements. E.g. ORMultiMap[String].

huntc commented 9 years ago

I like it even before I've looked at it!

hseeberger commented 9 years ago

@patriknw, I love it!

huntc commented 9 years ago

I've only looked at ORMultiMap in detail and it looks great overall.

I'm curious, why the change of heart in terms of adding the type param here? I'm happy that you have, just curious.

patriknw commented 9 years ago

why the change of heart in terms of adding the type param here

yes, it looks obvious now. I guess my previous failed attempts added the types at the wrong level. I think I tried to add things to ReplicatedData.

huntc commented 9 years ago

LGTM

hseeberger commented 9 years ago

Looking forward to the next release ;-)