search

patriknw / akka-typed-blog

Sample code for the Akka Typed blog series
Other
50 stars 12 forks source link

Mirgrate to akka typed 2.5.7 #18

Closed Jentsch closed 6 years ago

Jentsch commented 6 years ago

I updated the source code to work with akka-typed 2.5.7.

Since the blog post uses the 2.5.7-M1 API, may a short notice about the changes (or even a new blog post) would be helpful. Or just discard this pull request to avoid confusion. I'm not sure how to handle the relation between blog post and this repository.

Kind regards, Jentsch

raboof commented 6 years ago

Perhaps we should even just retroactively update the blogpost to the new API? (it's at https://github.com/akka/akka.github.com)

patriknw commented 6 years ago

Excellent, thanks a lot @Jentsch

Could you also create a PR for the blog posts? Code is copied there. https://github.com/akka/akka.github.com/tree/master/blog/_posts

I want to keep these examples up to date with latest, and also update the blog posts, since we don't have much other documentation. I don't think we need writing migration guides yet. Too many things are still moving. PRs like this is a good guide for others though.

Jentsch commented 6 years ago

Yes, give me a little bit time. Hopefully around Monday an PR to update the blog post should arrive.

patriknw commented 6 years ago

that's great, thanks