Closed nick-klaviyo closed 1 year ago
Thank you for the PR. Could you check that npm test
is succeeding. Seems like eslint
wants some changes.
Furthermore, it would be nice to edit the resolve
method in index.d.ts
to also allow to return the object.
Thank you for the PR. Could you check that
npm test
is succeeding. Seems likeeslint
wants some changes. Furthermore, it would be nice to edit theresolve
method inindex.d.ts
to also allow to return the object.
Thanks - I've added the missing comma that was failing eslint
and updated index.d.ts
- let me know if that additional return type is what you were thinking.
Also: is there additional configuration I need to do locally in order to run NVM. I had some additional files eslint was catchingeslint
? If I run the pretest
npm script locally I get thousands of errors across all the project files. Something must be off with my settings 🤔
let me know if that additional return type is what you were thinking.
I was thinking of { path: string, module?: string }
as you can optionally also return a new module name that should be used for lookup.
And maybe add /test/additional-modules/my-es-module/index.js
to the .eslintignore
to make eslint
happy.
Seems good to me now. Thank you.
Thank you!
@XmiliaH Do you know when this will be released?
I am busy over the weekend. Will try to do it on Monday.
The new version is released
The new version is released
Thanks!
Support resolution of conditional export packages with customer resolver. This change implements the solution described in https://github.com/patriksimek/vm2/issues/504