search

patriksvensson / cupboard

A framework for provisioning local environments to a desired state, using the .NET SDK.
MIT License
761 stars 19 forks source link

remove Mono.Posix.NETStandard ? #43

Closed jetersen closed 2 years ago

jetersen commented 2 years ago

@patriksvensson I was exploring the last native dependency: Mono.Posix.NETStandard, I tried removing it and I could still build the project.

is there any reason for it?

https://github.com/patriksvensson/cupboard/blob/5b934948cc3446fe5ab3d1945df9faf46e488c9e/src/Cupboard.Core/Cupboard.Core.csproj#L16

patriksvensson commented 2 years ago

@jetersen No, it should be implicitly imported via Spectre.IO so should be able to remove that one.

jetersen commented 2 years ago

Next question, any reason Spectre.IO is pulling it in 🤔

Right, only to call create symlink which got support for in dotnet 6.

I'll see if I can create a PR that removes Mono.Posix.NETStandard on dotnet 6 👏

jetersen commented 2 years ago

https://github.com/spectresystems/spectre.io/pull/2 👏

jetersen commented 2 years ago

Right with https://github.com/spectresystems/spectre.io/pull/2 it actually means we now need to explicit depend on Mono.Posix.NETStandard as we use it for file access API