search

patrix87 / PowerShellGSM

A Comprehensive PowerShell Tool for Simple Automated Game Server Management.
https://github.com/patrix87/PowerShellGSM/
MIT License
111 stars 19 forks source link

Fixed SessionName (requires doublequotes for names with spaces), added Mods, SaveFolder and ExtraParams for extra dash parameters. #22

Closed simonghpub closed 11 months ago

patrix87 commented 11 months ago

I'm working on integrating those changes.

patrix87 commented 11 months ago

I've modified your PR a bit, can you validate it on your side again. It looked like it was working fine on my side.

simonghpub commented 11 months ago

Removal of the doublequotes for the SessionName makes the server ignore the specified port and listens on the default 7777 instead. 

SessionName            = "PowerShellGSM Ark Ascended Server"
"?SessionName=`"$($Server.SessionName)`"",

spaces_noquotes

SessionName            = "PowerShellGSM_NoSpacesHere"
"?SessionName=`"$($Server.SessionName)`"",

nospaces_noquotes

SessionName            = "PowerShellGSM Ark Ascended Server"
"?SessionName=`"`"`"$($Server.SessionName)`"`"`"",

spaces_withquotes

The rest seems fine :)

patrix87 commented 11 months ago

Oh thanks, I did not notice that. It's very odd how it will escape double quotes in the server password field but not the serveradminpassword or session name...

patrix87 commented 11 months ago

@simonghpub Were you able to get the MaxPlayers working ?

simonghpub commented 11 months ago

Yeah, I don't get it either with the doublequotes. About the maxplayers: I see you got it working, nice :)