search

patrodyne / hisrc-basicjaxb

XJC plugins and tools for JAXB.
BSD 3-Clause "New" or "Revised" License
16 stars 6 forks source link

Missing toString and equals dependencies from hisrc-basicjaxb-tools v2.1.0 #3

Closed DyllanSowersTR closed 1 year ago

DyllanSowersTR commented 1 year ago

Version 2.0.0 included these classes but 2.1.0 does not: org.jvnet.basicjaxb.lang.Equals2; import org.jvnet.basicjaxb.lang.EqualsStrategy2;

import org.jvnet.basicjaxb.lang.ToString2; import org.jvnet.basicjaxb.lang.ToStringStrategy2;

However the -XtoString and -Xequals plugins still generate with these classes included. Was this an intentional relocation of the class or a mistake?

patrodyne commented 1 year ago

Dyllan, intentional. V2.1.0 moved the org.jvnet.basicjaxb.lang.Foo2 classes to their older and deprecated equivalent names; thus, replacing the deprecated versions with the newer Foo2 behavior. For example, org.jvnet.basicjaxb.lang.Equals2 became org.jvnet.basicjaxb.lang.Equals which is now new and undeprecated, again. FTR, the newer behavior includes the locator pattern and isSet detection.

With regard to your observation, "the -XtoString and -Xequals plugins still generate with these classes included." My testing shows the opposite, that the v2.1.0 plugins generate org.jvnet.basicjaxb.lang.Equals and org.jvnet.basicjaxb.lang.ToString, etc. As a sanity check, I downloaded the hisrc-basicjaxb-plugins-2.1.0-sources.jar and hisrc-basicjaxb-runtime-2.1.0-sources.jar from the Maven Central Index and verified the "2-lessness". Your observation may have been due to timing. It takes me a few days to release all five HiSrc projects and you may have hit a split brain scenario.