search

patronage / bubs-next

Headless Wordpress + Next.js Project scaffolding
https://bubs-next.vercel.app
MIT License
37 stars 10 forks source link

feat: NPM/Yarn Dependency Pinning #259

Closed kylehotchkiss closed 1 year ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated | | :--- | :----- | :------ | :------- | :------ | | **bubs-next** | ⬜️ Ignored ([Inspect](https://vercel.com/patronage/bubs-next/D2NqGPD1Mbtto9hPyaKhCwtnMeR6)) | [Visit Preview](https://bubs-next-git-225-pin-dependencies-patronage.vercel.app) | | Feb 10, 2023 at 0:11AM (UTC) |
ccorda commented 1 year ago

Do we need the defaultSemverRangePrefix: "" and adding the extra config file? Quickly googling i thought the npmrc was all you needed.

kylehotchkiss commented 1 year ago

Yarn doesn't read .npmrc as that is specifically for NPM. The config file I've added is the equivalent config for Yarn. This stack overflow thread is where I found this

ccorda commented 1 year ago

That says it's for yarn 2, which i don't think we want to imply support for.

And I believe it does pin with .npmrc: https://maxleiter.com/blog/pin-dependencies

kylehotchkiss commented 1 year ago

Turns out I'm not even on Yarn 2, despite just installing it two weeks ago. Fair enough, I'll remove the file for now. Can reconsider when we see yarn 2 rolled out more widely.