patronage / bubs-next

Headless Wordpress + Next.js Project scaffolding
https://bubs-next.vercel.app
MIT License
37 stars 10 forks source link

Disable gutenberg in functions.php #267

Closed chrisherold closed 1 year ago

chrisherold commented 1 year ago

fixes #266

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Updated | | :--- | :----- | :------ | :------ | | **bubs-next** | ⬜️ Ignored ([Inspect](https://vercel.com/patronage/bubs-next/AM8usen9hR8QZDMmmqzQjp96sXfW)) | | Feb 17, 2023 at 8:12PM (UTC) |
ccorda commented 1 year ago

I'm down to remove the gutenberg ramp, but I'm not seeing this as an improvement over the official classic editor -- is there something this gets us that doesn't to see us change things?

If we were to roll our own, then I think we'd need to have it be inside a dedicated helper file so we can easily update it by rsyncing in a new version, rather than having something hardcoded into the functions.php which is harder to update.

chrisherold commented 1 year ago

The classic editor is built into wordpress, the php just disables gutenberg so the classic editor is then the default. All the classic editor plugin does is block gutenberg globally and allow you to toggle back and forth between gutenberg and classic on individual pages, which we don't use anyway.

ccorda commented 1 year ago

Please note that this plugin is deprecated. The WordPress core filters should be used instead. See here.

I'm warming to the idea of this PR beyond simply removing plugins.

In particular because in Timber, we'll want to also remove the CSS: https://smartwp.com/remove-gutenberg-css/

On the other hand, I do see us needing to support gutenberg in the future, especially as we look at Faust. I think the feedback I have here is to:

ccorda commented 1 year ago

Implemented in #287