Closed chrisherold closed 4 years ago
Thanks @chrisherold . Gave this a go. A few early impressions.
background-color: black
on the body class of a page. but the browser didn't reflect the change automatically. It only did when i manually refreshed the browser page. Can someone else confirm these issues? Or are they mine specifically?
My local setup:
$ gulp --version
CLI version: 2.2.0
Local version: 4.0.2
$ node --version
v12.16.2
$ ./node_modules/gulp/bin/gulp.js --version
CLI version: 2.2.0
Local version: 4.0.2
$ ./node_modules/browser-sync
browser-sync/ browser-sync-client/ browser-sync-ui/
$ ./node_modules/browser-sync/dist/bin.js --version
2.26.7
$
Got a chance to troubleshoot the issue i raised above and have a PR, #120 , into this PR's branch, new-gulp
. Seems to fix the scss watch browsersync not injecting the updated css, and still using the stream api rather than doing a full browser refresh. More details i that PR
@chrisherold , feel free to look that PR over and merge into here, if it looks good. I think after that fix, this gulp upgrade might be good to go, unless someone else wants to have a look.
Just tested this branch new-gulp
with @chrisherold 's updates in e5ba5a51 . Gulp watch scss updates (stream injected) is now working fine. Gulp watch js is as well for normal reloads. the dist/ directory seems to generate fine, and @chrisherold tested a deploy with it to a staging site on one of our project.
So this upgraded gulp 4 setup looks fine to me to merge to master and start using, unless anyone else wants to test.
This upgrades gulp to v4 and updates all packages. The gulp file is renamed to
gulpfile.babel.js
and uses@babel/register
and a.babelrc
file to tell gulp to compile the ES6. It adds a step in the scripts task to compile any ES6 JS in theassets/js
using Babel. The.nvmrc
is set to the current version of Node 12.Also bumped all composer packages as well.