Closed yuvilio closed 4 years ago
Thanks for looking that over, @chrisherold .
Sure, i'm fine with your alternate adjust, e5ba5a51 , if it resolves the gulp watch for scss and the reload is a stream one. Can test that shortly.
I'm not sure a separate gulp debug
is worth cramming into this PR. That's why i just left the commented sample for now. But open to it in a separate PR.
Good spot on the node-sass being pre-release. I got fooled.. definitely not a must upgrade since youre main PR does the big jump upgrade there, as it is.
Changes discussed here were merged into the main PR , #118. Closing this PR in favor of that one.
This PR addresses some issues raised in PR #118 . That is, provides changes from this branch
118-new-gulp-adjusts
for that PR's branch,new-gulp
(notmaster
)It gives css its own reload function for streaming. The other tasks (like js) still use the standard reload as before.
This was tested with node v12.16.2
The gulpconfig.json override is now an additive one, rather than either/or. the json file still overrides the default values when present. It's just on a key by key case rather than all or nothing.
Additionally we bump gulp-sass and node-sass to the latest stable versions (slight increase from already upgraded ones).
Also added gulp-debug for future pipe debugging.We added one commented out sample usage, so it doesn't affect build time.
Also have any errors in handleErrors display as well in the console, for extra visibility.
In addition to scss, I also tested a trivial js change in main.js and the page reloaded correctly. I also tested and gulp release and the
dist/
assets generate fine.@chrisherold , can you look this over and if it looks fine, merge? (it will merge into the
gulp-new
branch from PR #118 . Otherwise questions/comments welcome.