patronage / bubs-timber

Gulp + Timber + WP
Other
5 stars 1 forks source link

Better way of loading private plugins #126

Closed ccorda closed 2 years ago

ccorda commented 4 years ago

We can't include zips in public repos for private code we don't have access to. This has always been a problem with ACF for example.

Our current way of handling is to have working empty.zip in there for ACF, then remember to update when we clone to private. Sometimes though if you forget to update after changing the version number, you end up with a bad version in your composer cache, which is always harder to solve than it should be.

ccorda commented 4 years ago

refs #80 refs #109

ccorda commented 4 years ago

Some research that seems like it'd work:

https://github.com/ffraenz/private-composer-installer https://support.advancedcustomfields.com/forums/topic/installing-acf5-via-composer/

ccorda commented 4 years ago

One other option, though i think the private zip of the last one is better: https://roots.io/guides/private-or-commercial-wordpress-plugins-as-composer-dependencies/

ccorda commented 4 years ago

This too: https://roots.io/guides/acf-pro-as-a-composer-dependency-with-encrypted-license-key/

ccorda commented 2 years ago

We use the key ENV variable approach as of https://github.com/patronage/bubs-timber/commit/469a52c5a4551b4d9a0dc346c4da12f1c6e886f5, closing.