Closed yuvilio closed 3 years ago
I think I'd want all of those things in init.sh
to happen when i run composer update
. I feel like there have been times where myself and others have not run composer install
after running composer update
and then things aren't set how they are supposed to be.
On the composer side of things it seems like composer update
is doing everything that is needed and I don't need to run composer install
afterward except to trigger the init.sh
so I can just have it run after update and be done. Is there anything to be gained on the composer side by running composer install
after a composer update
?
This PR upgrades wordpress core/plugins including process adjusts in doing go:
This includes :
$PLUGIN_ACF_KEY
environment variable to your local environment.@chrisherold , one note. In composer.json, I removed the post-update-cmd init.sh entry in "scripts" because it makes
composer update
's functionality overlap with composer install. I see update as just focused on prep of composer.lock and the build directory (composer/
) whilecomposer install
being the one that carries out the install to the root directory. init.sh seems to just contribute to the installation. Chime in if you think otherwise.We've tested it on recent big clients and it looks good. I also just tested it on bubs local instance.