Closed kevincianfarini closed 1 month ago
I've pushed some edits. They:
color
and size
to both of the composable functions. The defaults for these values correspond to the value in the TextStyle
. CI won't run until you approve, so consider this a ping 😄
Hello @kevincianfarini, thanks for your contribution! Regarding @patrickmichalik’s comment, he meant that we shouldn't use TextStyle
as a parameter. That’s because we won’t use most of its properties. Instead, we should directly accept FontFamily
, FontWeight
, FontStyle
, and FontSynthesis
.
Ah I see, I can rework that.
I'm going to have to follow up on this next week since I'm going to be out of the office. Sorry for the delay!
No worries at all, @kevincianfarini! There’s no rush here. Thanks for letting us know.
Hey, sorry, things have gotten extremely busy with work. I will try to get this over the finish line in the next couple of weeks, though if you'd prefer please feel free to take this over. I won't be offended.
No problem. Thanks for the update!
Closing due to inactivity.
The functions
rememberTextComponent
andrememberAxisLabelComponent
now both accept aTextStyle
that dictates the text's color, size, and font. Previously, these functions accepted three parameters for these values. This was awkward for Compose callers, particularly for theandroid.graphics.Typeface
value.