patrykandpatrick / vico

A light and extensible chart library for Android.
https://patrykandpatrick.com/vico/wiki
Apache License 2.0
2.08k stars 125 forks source link

ColumnChart with MergeMode.Grouped does not receive callback for all the series added through CartesianMarkerVisibilityListener #711

Closed puregallery closed 3 months ago

puregallery commented 4 months ago

How to reproduce

Create a ColumnChart with two series, add a marker and CartesianMarkerVisibilityListener. Drag across all the columns/bars

Observed behavior

We are getting a single callback for both entries in the series.

Expected behavior

I expect a callback for both the columns...even with the same x value.

Vico version(s)

alpha19

Android version(s)

14

Additional information

No response

patrickmichalik commented 4 months ago

Hello! Thanks for the report. We’ll look into it.

I previously misread the issue and thought that it referred to expected behavior, leading me to close it. I’ve now reopened the issue. Apologies for the confusion.

Gowsky commented 3 months ago

Hello, Vico 2.0.0-alpha.21 fixes this. Remember to override both onShown and onUpdated to receive all of the required callbacks.