search

patrykandpatrick / vico

A light and extensible chart library for Android.
https://patrykandpatrick.com/vico/guide
Apache License 2.0
2.18k stars 131 forks source link

Unable to scroll HorizontalPager when marker is set #942

Open shervinkoushan opened 4 weeks ago

shervinkoushan commented 4 weeks ago

How to reproduce

Create a chart with a marker. Put the chart in a HorizontalPager.

Observed behavior

Unable to scroll the pager as the marker consumes all touch events.

Expected behavior

Possible to scroll the pager and highlight points by clicking on them.

Vico version(s)

2.0.0-beta.2

Android version(s)

14

Additional information

No response

Gowsky commented 3 weeks ago

Hello, @shervinkoushan. Thank you for the report. It happens only for charts that aren't scrollable. We'll look into it.

shervinkoushan commented 3 weeks ago

Hi @Gowsky. I am indeed able to scroll the HorizontalPager when I set scrollEnabled to true on the chart. It would be nice if the marker was not shown when scrolling though.

Gowsky commented 3 weeks ago

We plan on adding such an option. Please see this comment.