patsonluk / airline

Apache License 2.0
109 stars 71 forks source link

Upgrade to Play 2.8.x #617

Closed k2-99 closed 1 month ago

k2-99 commented 1 month ago

Why

Play 2.8.x is compatible with apple silicon, I had difficulties getting the older version setup.

Categories of Changes

Dependency Upgrades

Bumped Akka to 2.6.21

Official Migration Guide. Most notably default remoting is now 'Artery TCP'. Some changes to application.conf otherwise you'll get some start-up issues with ports already in use (artery also changed the default port, but I overrode that back to what you were using).

Bumped Scala to 2.13.11

Fixed a lot of upcoming Scala 3 warnings, most notably calling a method without ().

Guice

Need to specify two Guice Specific libraryDependencies in build.sbt otherwise you'll get a cache exception. These were recommended by Play when using JDK >= 17. (Lost the link, sorry)

Writes.traversableWrites is deprecated

Official Docs recommend iterableWrites

Play.current is deprecated

Removed usage from a few views. Same for play.api.i18n.Messages.Implicits._

Styling

Sorry, my VSCode settings on code style ended up changing a lot before I noticed.


Testing

Got airline-web and airline-data both running. Did basic testing on airline-web (Create new user/airline, select base, setup some routes). Let me know if you have an SOP for testing and I can do that in the future as well.

k2-99 commented 1 month ago

Closing in favor of 3.0.x upgrade: https://github.com/patsonluk/airline/pull/618